Skip to content

ROU-12717: Fix name of added event to marker pop-up#258

Merged
rugoncalves merged 4 commits intodevfrom
ROU-12717
Apr 27, 2026
Merged

ROU-12717: Fix name of added event to marker pop-up#258
rugoncalves merged 4 commits intodevfrom
ROU-12717

Conversation

@rugoncalves
Copy link
Copy Markdown
Contributor

This PR is for simply attaching to the correct event in the case of the Google Advanced Marker. For the new version of the markers, the click event is gmp-click and not click.

What was happening

  • An warning was appearing in the console, when the click occurred.

What was done

  • Changed the static string to use instead the enumerate with the correct provider event;
  • Protected the code against errors;

Test Steps

  1. Go to the test page;
  2. Click on the marker;
  3. See if the pop-up appears;
  4. And if no warning appears in the console;

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

Copilot AI review requested due to automatic review settings April 23, 2026 09:34
@rugoncalves rugoncalves requested a review from a team as a code owner April 23, 2026 09:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Google Advanced Marker popup behavior to listen to the correct provider click event (gmp-click) via the existing constants enum, and attempts to harden popup content refresh to avoid runtime errors.

Changes:

  • Switched marker popup click listener from a hard-coded 'click' string to Constants.Marker.ProviderEventNames.click (maps to gmp-click).
  • Initialized _contentString with a default empty string.
  • Updated refreshPopupContent() to use optional chaining / fallback when reading popup DOM content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Providers/Maps/Google/Marker/MarkerPopup.ts
Comment thread src/Providers/Maps/Google/Marker/MarkerPopup.ts
Comment thread src/Providers/Maps/Google/Marker/MarkerPopup.ts
@joselrio
Copy link
Copy Markdown
Contributor

@rugoncalves Is it supposed to have failing tests still?

@sonarqubecloud
Copy link
Copy Markdown

@rugoncalves rugoncalves merged commit a7495aa into dev Apr 27, 2026
16 checks passed
@rugoncalves rugoncalves deleted the ROU-12717 branch April 27, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants